Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed fragment to show 404 when discussion tab is clicked #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

changed fragment to show 404 when discussion tab is clicked #5

wants to merge 3 commits into from

Conversation

muhammadadeeltajamul
Copy link
Owner

@muhammadadeeltajamul muhammadadeeltajamul commented Jan 4, 2022 •
edited
Loading

Show 404 when discussion tab is clicked

fragment body in view has been changed to show "Error 404: NOT Found" instead of showing the template code of fragment body.

awaisdar001
awaisdar001 suggested changes Jan 11, 2022
View reviewed changes
Copy link

@awaisdar001 awaisdar001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not like this, you have to to override is_enabled method. see here.
https://github.com/edx/edx-platform/blob/6d8a77ad1556e57f7d082602c4661b13de72c37b/lms/djangoapps/discussion/plugins.py#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaisdar001 awaisdar001 awaisdar001 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muhammadadeeltajamul @awaisdar001